fix: add types definitions #76
Conversation
|
Please add a test for the type using http://npm.im/tsd |
|
@mcollina Could you give a look at this? |
|
@robertsLando @mcollina Could you have a look at the changes you requested ? |
abstract.js
Outdated
| function orderedKeys (inputObj) { | ||
| return Object.keys(inputObj).sort().reduce((obj, key) => { | ||
| obj[key] = inputObj[key] | ||
| return obj | ||
| }, {}) | ||
| } |
There was a problem hiding this comment.
LOL that's so tricky 😕 I have all aedes repos with tape to update but with version 5 I think there is definetly something that isn't working... @mcollina thoughts on this? I also tried to open an issue about this on tape: tape-testing/tape#508
They suggested me to use deepLooseEqual but last time I tried seems also thaat wasn't working
There was a problem hiding this comment.
Ahah i can imagine, you were more brave than me by digging into tape.
I just tried deepLooseEqual and it seems to work.
There was a problem hiding this comment.
Good news, maybe in last year they have fixed something 😆 I was quite sure it wasn't working when I tried, If you check all other aedes repos need this fix...
The name of the PR says it all.